Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: Events UI Edits #641

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

UX: Events UI Edits #641

wants to merge 6 commits into from

Conversation

jordanvidrine
Copy link
Contributor

This PR restyles the current events post UI:

  • Minimize size of invitee avatars
  • move CTA buttons to bottom
  • remove invitee header & show more button (show more is in ellipses drop down)
  • restyle border
  • restyle month & date size & spacing
  • increase font size for title
  • add "0 going" placeholder to prevent jumpiness when invitees are rendered

Before
image

After
image

@jordanvidrine jordanvidrine marked this pull request as ready for review November 4, 2024 19:28
jjaffeux
jjaffeux reviewed Nov 8, 2024
View reviewed changes
assets/stylesheets/common/discourse-post-event.scss
@@ -205,7 +246,7 @@ $interested: #fb985d;
flex-direction: column;

.header {
display: flex;
display: none;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have it if we don't show it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I felt it was too drastic to remove for now? This is a hard one. If someone still wants this header with the "show all" button, I was afraid of removing it.

I am fine to remove it though as we are still giving people the option to show header in the ellipsis menu.

@jordanvidrine jordanvidrine force-pushed the events-edits-small branch 2 times, most recently from b3f5069 to 96a1f3d Compare November 8, 2024 19:03
@CvX CvX changed the title UX: Events UI Edits UX: Events UI Edits Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjaffeux jjaffeux jjaffeux left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanvidrine @jjaffeux